Review der Codebase

LehrerApp.Data/LiteDbContext.cs

@@ -60,6 +60,21 @@ public class LiteDbContext : IDisposable
 
     public int SchemaVersion => ReadSchemaVersion();
 
+    internal void ExecuteInTransaction(Action action)
+    {
+        _db.BeginTrans();
+        try
+        {
+            action();
+            _db.Commit();
+        }
+        catch
+        {
+            _db.Rollback();
+            throw;
+        }
+    }
+
     private void RunVersionedMigrations()
     {
         var version = ReadSchemaVersion();

LehrerApp.Data/Repositories/AllRepositories.cs

@@ -40,40 +40,74 @@ public class GroupRepository(LiteDbContext db) : IGroupRepository
     }
     public void Delete(Guid id)
     {
-        foreach (var membership in db.Memberships.Find(e => e.GroupId == id).ToList())
-            db.Memberships.Delete(membership.Id);
-
-        foreach (var exam in db.Exams.Find(e => e.GroupId == id).ToList())
+        db.ExecuteInTransaction(() =>
         {
-            foreach (var result in db.ExamResults.Find(r => r.ExamId == exam.Id).ToList())
-                db.ExamResults.Delete(result.Id);
-            db.Exams.Delete(exam.Id);
-        }
+            foreach (var membership in db.Memberships.Find(e => e.GroupId == id).ToList())
+                db.Memberships.Delete(membership.Id);
 
-        foreach (var grade in db.Grades.Find(g => g.GroupId == id).ToList())
-            db.Grades.Delete(grade.Id);
+            foreach (var exam in db.Exams.Find(e => e.GroupId == id).ToList())
+            {
+                foreach (var result in db.ExamResults.Find(r => r.ExamId == exam.Id).ToList())
+                    db.ExamResults.Delete(result.Id);
+                db.Exams.Delete(exam.Id);
+            }
 
-        foreach (var unit in db.Units.Find(u => u.GroupId == id).ToList())
-        {
-            foreach (var lesson in db.Lessons.Find(l => l.UnitId == unit.Id).ToList())
+            foreach (var grade in db.Grades.Find(g => g.GroupId == id).ToList())
+                db.Grades.Delete(grade.Id);
+
+            foreach (var reportGrade in db.ReportGrades.Find(g => g.GroupId == id).ToList())
+                db.ReportGrades.Delete(reportGrade.Id);
+
+            foreach (var scheme in db.GradingSchemes.Find(s => s.GroupId == id).ToList())
+                db.GradingSchemes.Delete(scheme.Id);
+
+            foreach (var unit in db.Units.Find(u => u.GroupId == id).ToList())
+            {
+                foreach (var lesson in db.Lessons.Find(l => l.UnitId == unit.Id).ToList())
+                    db.Lessons.Delete(lesson.Id);
+                db.Units.Delete(unit.Id);
+            }
+
+            foreach (var lesson in db.Lessons.Find(l => l.GroupId == id).ToList())
                 db.Lessons.Delete(lesson.Id);
-            db.Units.Delete(unit.Id);
-        }
 
-        foreach (var lesson in db.Lessons.Find(l => l.GroupId == id).ToList())
-            db.Lessons.Delete(lesson.Id);
+            foreach (var session in db.ParticipationSessions.Find(s => s.GroupId == id).ToList())
+            {
+                foreach (var entry in db.ParticipationEntries.Find(e => e.SessionId == session.Id).ToList())
+                    db.ParticipationEntries.Delete(entry.Id);
+                db.ParticipationSessions.Delete(session.Id);
+            }
 
-        foreach (var session in db.ParticipationSessions.Find(s => s.GroupId == id).ToList())
-        {
-            foreach (var entry in db.ParticipationEntries.Find(e => e.SessionId == session.Id).ToList())
-                db.ParticipationEntries.Delete(entry.Id);
-            db.ParticipationSessions.Delete(session.Id);
-        }
+            foreach (var aspect in db.ParticipationAspects.Find(a => a.GroupId == id).ToList())
+                db.ParticipationAspects.Delete(aspect.Id);
 
-        foreach (var aspect in db.ParticipationAspects.Find(a => a.GroupId == id).ToList())
-            db.ParticipationAspects.Delete(aspect.Id);
+            foreach (var section in db.ParticipationSections.Find(s => s.GroupId == id).ToList())
+                db.ParticipationSections.Delete(section.Id);
 
-        db.Groups.Delete(id);
+            // Dokumentation und Arbeitszeit sind historische Nachweise. Sie bleiben erhalten,
+            // werden aber von der nicht mehr existierenden Lerngruppe entkoppelt.
+            foreach (var documentation in db.Documentation.Find(d => d.GroupId == id).ToList())
+            {
+                documentation.GroupId = null;
+                documentation.UpdatedAt = DateTime.UtcNow;
+                db.Documentation.Update(documentation);
+            }
+
+            foreach (var task in db.Tasks.Find(t => t.GroupId == id).ToList())
+            {
+                task.GroupId = null;
+                task.UpdatedAt = DateTime.UtcNow;
+                db.Tasks.Update(task);
+            }
+
+            foreach (var timeEntry in db.TimeEntries.Find(t => t.GroupId == id).ToList())
+            {
+                timeEntry.GroupId = null;
+                db.TimeEntries.Update(timeEntry);
+            }
+
+            db.Groups.Delete(id);
+        });
     }
 }