feat: Kompetenzzuordnungen von Freitext-Code auf stabile CompetencyItem.Id umgestellt (TODO 16.5)
Unit/Lesson/ExamTask/ParticipationSession referenzierten Kompetenzen bisher per Freitext-Code, case-insensitiv gegen den Katalog gematcht - fragil bei Umbenennungen und seit der Bildungsplan-Versionierung nicht mehr eindeutig (zwei Versionen können denselben Code vergeben). Neuer Werttyp CompetencyReference (ItemId + Code/Description-Momentaufnahme) löst das: solange die Id noch im Katalog auflösbar ist, zählt die live Fassung (Rename wirkt sofort), sonst bleibt die gespeicherte historische Fassung sichtbar statt spurlos zu verschwinden. Migration (Schema-Version 6) löst bestehende Codes gegen den Katalog auf; die zuvor dreifach duplizierte Kompetenz-Tag-UI ist jetzt in CompetencyTagGroupBuilder konsolidiert. add_lesson_competency/remove_lesson_competency nehmen jetzt itemId statt code und validieren gegen den Katalog (vorher ungeprüft). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
f97edff2fe
commit
dc2f58c4dc
28 files changed
+691
-202
No files matched your search
@@ -8,6 +8,12 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
{
|
||||
private readonly CompetencyAnalysisService _service = new();
|
||||
|
||||
private static readonly CompetencyItem K1 = new() { Code = "K1", Description = "Erste Kompetenz" };
|
||||
private static readonly CompetencyItem K2 = new() { Code = "K2", Description = "Zweite Kompetenz", SortOrder = 1 };
|
||||
|
||||
private static CompetencyReference Ref(CompetencyItem item) =>
|
||||
new() { ItemId = item.Id, Code = item.Code, Description = item.Description };
|
||||
|
||||
[Fact]
|
||||
public void Analyze_UnterscheidetPlanungBehandlungUndPruefung()
|
||||
{
|
||||
@@ -15,16 +21,16 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
var catalog = Catalog();
|
||||
var units = new List<Unit>
|
||||
{
|
||||
new() { GroupId = groupId, Status = UnitStatus.Planned, Competencies = ["K1"] },
|
||||
new() { GroupId = groupId, Status = UnitStatus.Active, Competencies = ["K1"] },
|
||||
new() { GroupId = groupId, Status = UnitStatus.Completed, Competencies = ["K1"] },
|
||||
new() { GroupId = groupId, Status = UnitStatus.Planned, Competencies = [Ref(K1)] },
|
||||
new() { GroupId = groupId, Status = UnitStatus.Active, Competencies = [Ref(K1)] },
|
||||
new() { GroupId = groupId, Status = UnitStatus.Completed, Competencies = [Ref(K1)] },
|
||||
};
|
||||
var exams = new List<Exam>
|
||||
{
|
||||
new() { GroupId = groupId, Status = ExamStatus.Planned,
|
||||
Tasks = [new ExamTask { MaxPoints = 10, CompetencyCodes = ["K1"] }] },
|
||||
Tasks = [new ExamTask { MaxPoints = 10, Competencies = [Ref(K1)] }] },
|
||||
new() { GroupId = groupId, Status = ExamStatus.Graded,
|
||||
Tasks = [new ExamTask { MaxPoints = 10, CompetencyCodes = ["K1"] }] },
|
||||
Tasks = [new ExamTask { MaxPoints = 10, Competencies = [Ref(K1)] }] },
|
||||
};
|
||||
|
||||
var item = Assert.Single(_service.Analyze(catalog, units, exams, []));
|
||||
@@ -46,8 +52,8 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
Status = ExamStatus.Graded,
|
||||
Tasks =
|
||||
[
|
||||
new ExamTask { MaxPoints = 10, CompetencyCodes = ["K1"] },
|
||||
new ExamTask { MaxPoints = 20, CompetencyCodes = ["K1"] },
|
||||
new ExamTask { MaxPoints = 10, Competencies = [Ref(K1)] },
|
||||
new ExamTask { MaxPoints = 20, Competencies = [Ref(K1)] },
|
||||
],
|
||||
};
|
||||
var results = new List<ExamResult>
|
||||
@@ -69,13 +75,13 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Analyze_AufgabeMitMehrerenCodes_WertetJedeZugeordneteKompetenzAus()
|
||||
public void Analyze_AufgabeMitMehrerenKompetenzen_WertetJedeZugeordneteKompetenzAus()
|
||||
{
|
||||
var studentId = Guid.NewGuid();
|
||||
var exam = new Exam
|
||||
{
|
||||
Status = ExamStatus.Returned,
|
||||
Tasks = [new ExamTask { MaxPoints = 8, CompetencyCodes = ["K1", "K2"] }],
|
||||
Tasks = [new ExamTask { MaxPoints = 8, Competencies = [Ref(K1), Ref(K2)] }],
|
||||
};
|
||||
var result = new ExamResult { ExamId = exam.Id, StudentId = studentId, Points = [6] };
|
||||
|
||||
@@ -91,7 +97,7 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
var exam = new Exam
|
||||
{
|
||||
Status = ExamStatus.Conducted,
|
||||
Tasks = [new ExamTask { MaxPoints = 10, CompetencyCodes = ["K1"] }],
|
||||
Tasks = [new ExamTask { MaxPoints = 10, Competencies = [Ref(K1)] }],
|
||||
};
|
||||
var result = new ExamResult { ExamId = exam.Id, StudentId = studentId, Points = [5] };
|
||||
|
||||
@@ -103,30 +109,59 @@ public sealed class CompetencyAnalysisServiceTests
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Analyze_VerwendeterUnbekannterCode_BleibtInUebersichtSichtbar()
|
||||
public void Analyze_GeloeschteKompetenz_BleibtMitGespeicherterMomentaufnahmeSichtbar()
|
||||
{
|
||||
var unit = new Unit { Status = UnitStatus.Active, Competencies = ["ALT1"] };
|
||||
// ItemId zeigt auf kein (mehr) existierendes Katalog-Item (z.B. gelöscht) - Code/Description
|
||||
// stammen aus der zum Zuordnungszeitpunkt gespeicherten Momentaufnahme.
|
||||
var reference = new CompetencyReference
|
||||
{
|
||||
ItemId = Guid.NewGuid(), Code = "ALT1", Description = "Alte, inzwischen gelöschte Kompetenz",
|
||||
};
|
||||
var unit = new Unit { Status = UnitStatus.Active, Competencies = [reference] };
|
||||
|
||||
var analysis = _service.Analyze(Catalog(), [unit], [], []);
|
||||
|
||||
var unknown = Assert.Single(analysis, x => x.Code == "ALT1");
|
||||
Assert.Equal("Nicht im Katalog", unknown.DomainName);
|
||||
Assert.Equal("Alte, inzwischen gelöschte Kompetenz", unknown.Description);
|
||||
Assert.Equal(1, unknown.TaughtUnitCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Analyze_NieAufgeloesteReferenz_OhneBeschreibung_ZeigtFallbacktext()
|
||||
{
|
||||
// ItemId == Guid.Empty simuliert eine nie aufgelöste Referenz (z.B. aus einem
|
||||
// plattformübergreifenden Import über PlanningExchangeService) ohne gespeicherte Beschreibung.
|
||||
var reference = new CompetencyReference { ItemId = Guid.Empty, Code = "IMPORT1", Description = "" };
|
||||
var unit = new Unit { Status = UnitStatus.Active, Competencies = [reference] };
|
||||
|
||||
var analysis = _service.Analyze(Catalog(), [unit], [], []);
|
||||
|
||||
var unknown = Assert.Single(analysis, x => x.Code == "IMPORT1");
|
||||
Assert.Contains("nicht (mehr) im aktuellen Katalog", unknown.Description);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Analyze_UmbenannteKompetenz_ZeigtLiveFassungStattMomentaufnahme()
|
||||
{
|
||||
// Referenz trägt eine veraltete Momentaufnahme (Description von vor dem Rename) - solange
|
||||
// ItemId noch im Katalog auflösbar ist, muss die LIVE-Fassung gewinnen.
|
||||
var reference = new CompetencyReference { ItemId = K1.Id, Code = "K1", Description = "Veraltete Beschreibung" };
|
||||
var unit = new Unit { Status = UnitStatus.Active, Competencies = [reference] };
|
||||
|
||||
var item = Assert.Single(_service.Analyze(Catalog(), [unit], [], []));
|
||||
|
||||
Assert.Equal("Erste Kompetenz", item.Description);
|
||||
Assert.Equal("Bereich", item.DomainName);
|
||||
}
|
||||
|
||||
private static List<CompetencyDomain> Catalog(bool includeSecond = false) =>
|
||||
[
|
||||
new CompetencyDomain
|
||||
{
|
||||
Name = "Bereich",
|
||||
Code = "B",
|
||||
Items = includeSecond
|
||||
?
|
||||
[
|
||||
new CompetencyItem { Code = "K1", Description = "Erste Kompetenz", SortOrder = 0 },
|
||||
new CompetencyItem { Code = "K2", Description = "Zweite Kompetenz", SortOrder = 1 },
|
||||
]
|
||||
: [new CompetencyItem { Code = "K1", Description = "Erste Kompetenz" }],
|
||||
Items = includeSecond ? [K1, K2] : [K1],
|
||||
},
|
||||
];
|
||||
}
|
||||
@@ -183,6 +183,7 @@ public sealed class CompetencyCatalogImportServiceTests
|
||||
Current.Where(x => x.SubjectId == subjectId && x.GradeLevel == gradeLevel && x.VersionId == versionId).ToList();
|
||||
public List<CompetencyDomain> GetBySubjectAndVersion(Guid subjectId, Guid versionId) =>
|
||||
Current.Where(x => x.SubjectId == subjectId && x.VersionId == versionId).ToList();
|
||||
public List<CompetencyDomain> GetAll() => Current.ToList();
|
||||
public CompetencyDomain? GetById(Guid id) => Current.FirstOrDefault(x => x.Id == id);
|
||||
|
||||
public void Save(CompetencyDomain domain) => Current.Add(domain);
|
||||
|
||||
Reference in new issue
Block a user